Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210

grubberr · 2023-05-17T19:22:24Z

What

Try to fix this oncall https://github.com/airbytehq/oncall/issues/1954
I found one bug in my prev PR #26115

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions · 2023-05-17T19:22:43Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
You've updated the connector's metadata.yaml file new!

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-05-17T19:26:31Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5007144025
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5007144025
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        83      7    92%
source_file/client.py       330     56    83%
---------------------------------------------
TOTAL                       428     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       330     53    84%
source_file/utils.py         13      8    38%
source_file/source.py        83     62    25%
---------------------------------------------
TOTAL                       428    123    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 51.49s ========================

grubberr · 2023-05-17T19:39:28Z

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/5007240817

| Connector | Version | Did it publish? |
| --- | --- | --- | --- |
| connectors/source-file | 0.3.8 | ✅ |

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2023-05-17T20:24:32Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/5007599205

| Connector | Version | Did it publish? |
| --- | --- | --- | --- |
| connectors/source-file-secure | 0.3.8 | ✅ |

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

maxi297

Conditional approval: Given tests are updated, this change seems to make sense!

maxi297 · 2023-05-17T20:26:33Z

airbyte-integrations/connectors/source-file/source_file/client.py

@@ -96,7 +96,7 @@ def close(self):

    def backoff_giveup(self, error):
        # https://github.com/airbytehq/oncall/issues/1954
-        if isinstance(error, SSHException) and str(error) == "Error reading SSH protocol banner":
+        if isinstance(error, SSHException) and str(error).startswith("Error reading SSH protocol banner"):


Should we have a test changing in that case?

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

…tehq/airbyte into grubberr/oncall-1954-source-file-2

grubberr · 2023-05-17T21:17:31Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5007999658
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/5007999658
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        83      7    92%
source_file/client.py       330     56    83%
---------------------------------------------
TOTAL                       428     64    85%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       330     53    84%
source_file/utils.py         13      8    38%
source_file/source.py        83     62    25%
---------------------------------------------
TOTAL                       428    123    71%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 35 passed, 3 skipped in 50.55s ========================

…nner') - 2 (airbytehq#26210) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump 0.3.8

a863db4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this May 17, 2023

octavia-squidington-iii added area/connectors Connector related issues connectors/source/file connectors/source/file-secure labels May 17, 2023

file.md updated

6ef3a8e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 17, 2023

grubberr requested review from artem1205 and lazebnyi and removed request for artem1205 May 17, 2023 19:25

artem1205 approved these changes May 17, 2023

View reviewed changes

Automated Change

f3fb629

maxi297 approved these changes May 17, 2023

View reviewed changes

grubberr added 2 commits May 17, 2023 21:15

test_urlfile_open_backoff_sftp - improved

7bac023

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'grubberr/oncall-1954-source-file-2' of github.com:airby…

d19dd3e

…tehq/airbyte into grubberr/oncall-1954-source-file-2

grubberr merged commit 50c7cb4 into master May 17, 2023
18 of 20 checks passed

grubberr deleted the grubberr/oncall-1954-source-file-2 branch May 17, 2023 21:42

marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023

Source File: add retry on SSHException('Error reading SSH protocol ba…

b8fd0c7

…nner') - 2 (airbytehq#26210) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210

Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210

grubberr commented May 17, 2023 •

edited

Loading

github-actions bot commented May 17, 2023 •

edited by grubberr

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

maxi297 left a comment •

edited

Loading

maxi297 May 17, 2023

grubberr May 17, 2023

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210

Source File: add retry on SSHException('Error reading SSH protocol banner') - 2 #26210

Conversation

grubberr commented May 17, 2023 • edited Loading

What

github-actions bot commented May 17, 2023 • edited by grubberr Loading

Before Merging a Connector Pull Request

grubberr commented May 17, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented May 17, 2023 • edited by github-actions bot Loading

grubberr commented May 17, 2023 • edited by github-actions bot Loading

maxi297 left a comment • edited Loading

Choose a reason for hiding this comment

maxi297 May 17, 2023

Choose a reason for hiding this comment

grubberr May 17, 2023

Choose a reason for hiding this comment

grubberr commented May 17, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented May 17, 2023 •

edited

Loading

github-actions bot commented May 17, 2023 •

edited by grubberr

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading

maxi297 left a comment •

edited

Loading

grubberr commented May 17, 2023 •

edited by github-actions bot

Loading